[PWGJE] New code for hadronjet correlations of Jan Janis#16387
Open
fkrizek wants to merge 7 commits into
Open
Conversation
fkrizek
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 1 errors, |
Collaborator
|
Error while checking build/O2Physics/staging for e4c372b at 2026-05-26 10:49: Full log here. |
[PWGJE] Please consider the following formatting changes to AliceO2Group#16387
Collaborator
|
Error while checking build/O2Physics/o2 for e4c372b at 2026-05-26 10:52: Full log here. |
Collaborator
|
Please test the code properly before opening the PR for review. |
vkucera
reviewed
May 26, 2026
vkucera
reviewed
May 26, 2026
vkucera
reviewed
May 26, 2026
vkucera
reviewed
May 26, 2026
vkucera
reviewed
May 26, 2026
vkucera
reviewed
May 26, 2026
Collaborator
|
Please restore the commit history of this PR and reopen it. |
This was referenced May 26, 2026
fkrizek
added a commit
to fkrizek/O2Physics
that referenced
this pull request
May 26, 2026
[PWGJE] Please consider the following formatting changes to AliceO2Group#16387
[PWGJE] Please consider the following formatting changes to AliceO2Group#16387
nzardosh
requested changes
May 29, 2026
| #include "Common/DataModel/Multiplicity.h" | ||
|
|
||
| #include <CommonConstants/MathConstants.h> | ||
| #include <Framework/ASoA.h> |
Collaborator
There was a problem hiding this comment.
Could you please check if all these includes are needed? They were recently cleaned up so you could discuss with vit if these are an updated list
|
|
||
| using FilteredCollPartLevelMB = soa::Filtered<soa::Join<aod::JetMcCollisions, aod::BkgChargedMcRhos>>::iterator; | ||
|
|
||
| using CollPartLevelMBEfficiency = aod::JetMcCollisions::iterator; |
Collaborator
There was a problem hiding this comment.
for places where these are only used once you can directly use the table instead of this alias
| using namespace o2::framework::expressions; | ||
|
|
||
| using FilteredColl = soa::Filtered<soa::Join<aod::JetCollisions, aod::BkgChargedRhos>>::iterator; | ||
| using FilteredEventMultiplicity = soa::Filtered<soa::Join<aod::JetCollisions, aod::ZDCMults>>::iterator; |
Collaborator
There was a problem hiding this comment.
the ZDCMult table would not allow you to use the JE derived data. is the information needed?
|
|
||
| using FilteredTracksMatch = soa::Filtered<soa::Join<aod::JetTracks, aod::McTrackLabels>>; | ||
|
|
||
| using ParticlesFullTable = soa::Join<aod::JetParticles, aod::JMcParticlePIs>; |
Collaborator
There was a problem hiding this comment.
you should remove the PIs tables evrywhere since you dont actually access the original tables
|
|
||
| auto mcpjetsPerMCCollision = mcpjets.sliceBy(partJetsPerCollision, collision.mcCollisionId()); | ||
|
|
||
| fillMatchedHistograms(tracks, mcpjetsPerMCCollision, mcdjets); |
Collaborator
There was a problem hiding this comment.
does this not need a weight?
| float detJetPt = jetMatched.pt(); | ||
|
|
||
| spectra.fill(HIST("hJetPt_resolution"), (partJetPt - detJetPt) / partJetPt, partJetPt, weight); | ||
| spectra.fill(HIST("hJetPhi_resolution"), partJet.phi() - jetMatched.phi(), partJetPt, weight); |
Collaborator
There was a problem hiding this comment.
you are not wrapping phi. You should use the constrainAngle function in recodecay
| continue; | ||
|
|
||
| auto collTracks = tracks.sliceBy(tracksPerJCollision, collision.globalIndex()); | ||
| spectra.fill(HIST("hNTracksPerCollision"), collTracks.size()); |
Collaborator
There was a problem hiding this comment.
does this need a weight?
| while (bCloseJet) { | ||
| iii++; | ||
| if (iii > maxRandomConeIterations) { | ||
| break; |
Collaborator
There was a problem hiding this comment.
if this loop breaks previous values of randJetPhi are still used in line 495
| } | ||
|
|
||
| randJetPhi = rand.Uniform(-constants::math::PI, constants::math::PI); | ||
| randJetEta = rand.Uniform(-0.5, 0.5); |
Collaborator
There was a problem hiding this comment.
should it be a configurable?
|
|
||
| // Z coordinate of collision vertex | ||
| spectra.add("hVertexZ_NoCut", "z vertex of collisions w/o cut", kTH1F, {{100, -20., 20., "#it{z}_{vertex}"}}); | ||
| spectra.add("hVertexZ_Cut", "z vertex of collisions w. cut", kTH1F, {{100, -20., 20., "#it{z}_{vertex}"}}); |
Collaborator
There was a problem hiding this comment.
some histograms like this are never filled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a code of Jan Janis who is undergrad student of Filip Krizek. Jan will use this code to study hadron jet correlations.